Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 631813002: Remove obsolete path of getSources. (Closed)

Created:
6 years, 2 months ago by Henrik Grunell
Modified:
6 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, mkwst+moarreviews_chromium.org, philipj_slow, tommyw+watchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove obsolete path of getSources. The path for getSources has recently moved to UserMediaClient and this function is obsolete. BUG=420975 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183528

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M Source/platform/mediastream/MediaStreamCenter.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/platform/mediastream/MediaStreamCenter.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M public/platform/WebMediaStreamCenter.h View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Henrik Grunell
6 years, 2 months ago (2014-10-06 12:08:11 UTC) #2
Mike West
LGTM. Can you link to the Chromium-side (and previous Blink-side) patches in the CL description? ...
6 years, 2 months ago (2014-10-06 12:15:13 UTC) #3
Mike West
On 2014/10/06 12:15:13, Mike West wrote: > LGTM. Can you link to the Chromium-side (and ...
6 years, 2 months ago (2014-10-06 12:16:32 UTC) #4
Henrik Grunell
On 2014/10/06 12:16:32, Mike West wrote: > On 2014/10/06 12:15:13, Mike West wrote: > > ...
6 years, 2 months ago (2014-10-07 08:27:43 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-07 12:07:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631813002/20001
6 years, 2 months ago (2014-10-10 09:48:46 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 10:49:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183528

Powered by Google App Engine
This is Rietveld 408576698