Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 631803002: Replacing the OVERRIDE with override and FINAL with final (Closed)

Created:
6 years, 2 months ago by ARUNKK
Modified:
6 years, 2 months ago
Reviewers:
haraken, tkent, yurys
CC:
blink-reviews, Manuel Rego, fs, eric.carlson_apple.com, kouhei+svg_chromium.org, rwlbuis, krit, chromiumbugtracker_adobe.com, rune+blink, jchaffraix+rendering, pdr+svgwatchlist_chromium.org, jfernandez, zoltan1, eae+blinkwatch, philipj_slow, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, cbiesinger, blink-reviews-rendering, svillar, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in third_party/WebKit/Source/core/rendering This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183432

Patch Set 1 #

Patch Set 2 : Rebase issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M Source/platform/AsyncMethodRunner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODArena.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/PODIntervalTree.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RefCountedSupplement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Timer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/WebThreadSupportingGC.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/animation/AnimationValue.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/animation/TimingFunction.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/audio/Biquad.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/EqualPowerPanner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFPanner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/MultiChannelResampler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/SincResampler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/credentialmanager/PlatformFederatedCredential.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/credentialmanager/PlatformLocalCredential.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebMediaConstraints.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebMediaDeviceInfo.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebRTCICECandidate.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebRTCSessionDescription.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebSourceInfo.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebSpeechSynthesizerClientImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebStorageQuotaCallbacks.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DecodingImageGenerator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DisplayList.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DrawLooperBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContextState.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayerDebugInfo.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageDecodingStore.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/RegionTracker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEConvolveMatrix.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDropShadow.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FELighting.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMorphology.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEOffset.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FETile.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Handle.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamCenter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/MediaStreamDescriptor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamSource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/RTCConfiguration.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/RTCOfferOptions.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mhtml/ArchiveResource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mhtml/ArchiveResourceCollection.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mhtml/MHTMLArchive.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mhtml/MHTMLParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/plugins/PluginListBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollView.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlayMock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/speech/PlatformSpeechSynthesisUtterance.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/speech/PlatformSpeechSynthesisVoice.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/testing/ArenaTestHelpers.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/LineEnding.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/text/PlatformLocale.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/weborigin/KURL.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
ARUNKK
PTAL.
6 years, 2 months ago (2014-10-08 10:15:04 UTC) #2
ARUNKK
PTAL
6 years, 2 months ago (2014-10-08 10:17:25 UTC) #4
haraken
LGTM
6 years, 2 months ago (2014-10-08 10:35:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631803002/20001
6 years, 2 months ago (2014-10-08 12:21:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/30734)
6 years, 2 months ago (2014-10-08 14:16:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631803002/20001
6 years, 2 months ago (2014-10-09 01:29:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631803002/20001
6 years, 2 months ago (2014-10-09 05:12:59 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 06:22:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183432

Powered by Google App Engine
This is Rietveld 408576698