Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 631773003: Replacing the OVERRIDE with override and FINAL with final in content/browser/appcache (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/appcache This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/5217c57520fa657fcbf2e8fb5fbeb1bc34a2f5f4 Cr-Commit-Position: refs/heads/master@{#298260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -244 lines) Patch
M content/browser/appcache/appcache_disk_cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_disk_cache.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_disk_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_frontend_proxy.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/appcache/appcache_group.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_group_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/browser/appcache/appcache_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_host_unittest.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M content/browser/appcache/appcache_interceptor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_quota_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/appcache/appcache_request_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M content/browser/appcache/appcache_response.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_service_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_service_impl.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M content/browser/appcache/appcache_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl.cc View 13 chunks +24 lines, -24 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 13 chunks +24 lines, -24 lines 0 comments Download
M content/browser/appcache/appcache_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/appcache/appcache_update_job.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job.h View 3 chunks +11 lines, -11 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/mock_appcache_policy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/mock_appcache_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/mock_appcache_storage.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/browser/appcache/mock_appcache_storage_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/appcache/view_appcache_internals_job.cc View 11 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 13:07:14 UTC) #2
Avi (use Gerrit)
On 2014/10/06 13:07:14, MRV wrote: > PTAL Stampity stamp LGTM
6 years, 2 months ago (2014-10-06 14:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631773003/1
6 years, 2 months ago (2014-10-06 15:44:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 25c1ff1f111f2b6f93106452b26728558ff768b3
6 years, 2 months ago (2014-10-06 17:21:02 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 17:21:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5217c57520fa657fcbf2e8fb5fbeb1bc34a2f5f4
Cr-Commit-Position: refs/heads/master@{#298260}

Powered by Google App Engine
This is Rietveld 408576698