Issue 631763003: Make asan and lsan make flags work like on the bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 631763003: Make asan and lsan make flags work like on the bots. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach

Modified:
6 years, 2 months ago

Reviewers:
Igor Sheludko, Jakob Kummerow

CC:
v8-dev, Erik Corry Chromium.org

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	Makefile	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 7 (1 generated)

Jakob Kummerow

LGTM if we keep asan=/path/to/clang++ (use "export CC=$(dir $(asan))clang").

6 years, 2 months ago (2014-10-06 13:49:24 UTC) #4

Michael Achenbach

Done. Also fixed quotation marks - with them, the path to the symbolizer doesn't work.

6 years, 2 months ago (2014-10-06 14:21:45 UTC) #5

Michael Achenbach

6 years, 2 months ago (2014-10-06 15:21:50 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24419 (presubmit successful).