Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 631733002: Replacing the OVERRIDE with override and FINAL with final in ppapi (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in ppapi This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+796 lines, -796 lines) Patch
M ppapi/host/ppapi_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/host/resource_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/host/resource_message_filter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/host/resource_message_filter_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/lib/gl/include/GLES2/gl2ext.h View 1 chunk +1 line, -1 line 1 comment Download
M ppapi/nacl_irt/manifest_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.h View 1 chunk +14 lines, -14 lines 0 comments Download
M ppapi/proxy/audio_buffer_resource.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ppapi/proxy/audio_input_resource.h View 2 chunks +12 lines, -12 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/broker_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/browser_font_singleton_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/compositor_layer_resource.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ppapi/proxy/compositor_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/device_enumeration_resource_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_chooser_resource.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/file_io_resource.h View 1 chunk +15 lines, -15 lines 0 comments Download
M ppapi/proxy/file_mapping_resource.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/file_ref_resource.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ppapi/proxy/file_system_resource.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/flash_clipboard_resource.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/flash_drm_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/flash_file_resource.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ppapi/proxy/flash_font_file_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/flash_fullscreen_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/flash_menu_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/flash_resource.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/gamepad_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/graphics_2d_resource.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/host_resolver_private_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/host_resolver_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/isolated_file_system_private_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/media_stream_audio_track_resource.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/proxy/media_stream_track_resource_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/media_stream_video_track_resource.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ppapi/proxy/net_address_resource.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/network_list_resource.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/proxy/network_monitor_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/network_proxy_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/output_protection_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/pdf_resource.h View 1 chunk +17 lines, -17 lines 0 comments Download
M ppapi/proxy/platform_verification_private_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_array_buffer_var.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 2 chunks +14 lines, -14 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_resource_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource_var.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +19 lines, -19 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 3 chunks +13 lines, -13 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_flash_message_loop_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_flash_message_loop_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 3 chunks +14 lines, -14 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +58 lines, -58 lines 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_x509_certificate_private_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_x509_certificate_private_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_mouse_lock_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_text_input_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/printing_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_object_var.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/raw_var_data.h View 6 chunks +37 lines, -37 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 4 chunks +58 lines, -58 lines 0 comments Download
M ppapi/proxy/resource_message_params.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/resource_message_test_sink.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/talk_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/tcp_server_socket_private_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/tcp_socket_private_resource.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ppapi/proxy/tcp_socket_resource.h View 1 chunk +12 lines, -12 lines 0 comments Download
M ppapi/proxy/truetype_font_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/truetype_font_singleton_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/udp_socket_private_resource.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ppapi/proxy/udp_socket_resource.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ppapi/proxy/udp_socket_resource_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/uma_private_resource.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/url_loader_resource.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ppapi/proxy/url_request_info_resource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/proxy/url_response_info_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/video_capture_resource.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/video_decoder_resource.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ppapi/proxy/video_destination_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/video_frame_resource.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ppapi/proxy/video_source_resource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/websocket_resource.h View 1 chunk +14 lines, -14 lines 0 comments Download
M ppapi/shared_impl/array_var.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/dictionary_var.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/media_stream_buffer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_audio_config_shared.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/ppb_device_ref_shared.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ppapi/shared_impl/ppb_input_event_shared.h View 1 chunk +24 lines, -24 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_video_decoder_shared.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/ppb_view_shared.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ppapi/shared_impl/private/ppb_x509_certificate_private_shared.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/shared_impl/resource_tracker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/resource_var.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/test_globals.h View 2 chunks +20 lines, -20 lines 0 comments Download
M ppapi/shared_impl/thread_aware_callback_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/tracked_callback_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/var.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/var_tracker_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 11:09:58 UTC) #2
MRV
PTAL
6 years, 2 months ago (2014-10-06 11:10:02 UTC) #3
dmichael (off chromium)
I already approved another CL that's almost the same here: https://codereview.chromium.org/631733002/ You might want to ...
6 years, 2 months ago (2014-10-06 15:03:01 UTC) #4
dmichael (off chromium)
On 2014/10/06 15:03:01, dmichael wrote: > I already approved another CL that's almost the same ...
6 years, 2 months ago (2014-10-06 15:04:02 UTC) #5
Mostyn Bramley-Moore
@MRV: I added my patch to the CQ because because I think it doesn't have ...
6 years, 2 months ago (2014-10-06 15:37:43 UTC) #6
MRV
On 2014/10/06 15:37:43, Mostyn Bramley-Moore wrote: > @MRV: I added my patch to the CQ ...
6 years, 2 months ago (2014-10-06 15:49:34 UTC) #7
MRV
6 years, 2 months ago (2014-10-06 15:54:27 UTC) #8
On 2014/10/06 15:49:34, MRV wrote:
> On 2014/10/06 15:37:43, Mostyn Bramley-Moore wrote:
> > @MRV: I added my patch to the CQ because because I think it doesn't have the
> > same problem as this one.  I'm in #chromium if you want to ping me there so
we
> > can work on different parts of the tree (might be less noisy than in
> > crbug.com/417463).
> 
> Thanks mr.mostyn and mr. Dmichael for your suggestions.
> Iam looking to work more on content and third_party/WebKit folder..
> google_apis 
> I am going abandon this patch then.

Added to this.. i already submitted patches for mojo, remoting, u can observe
all my submisions to work to not to collide.

Thanks in advance
Mohan

Powered by Google App Engine
This is Rietveld 408576698