Issue 63173020: Split VTTCue from TextTrackCue

Issue 63173020: Split VTTCue from TextTrackCue (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit), Mike West

CC:
blink-reviews, Nils Barth (inactive), nessy, arv+blink, jsbell+bindings_chromium.org, marja+watch_chromium.org, gavinp+loader_chromium.org, philipj_slow, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, kojih, haraken, Nate Chapin, vcarbune.chromium, Inactive, gasubic

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Split VTTCue from TextTrackCue VTTCue has been split from TextTrackCue in the specs: http://whatwg.org/html#texttrackcue http://dev.w3.org/html5/webvtt/#vttcue-interface The TextTrackCue constructor is left for legacy compat until it is deemed safe to remove. To verify that it actually works, the tests still use the TextTrackCue constructor, but will be updated to use VTTCue in a later commit. Internal refactoring has been kept to a minimum, future commits should move more code from TextTrackCue to VTTCue. Thanks to Glenn Adams for starting this work and providing feedback! BUG=270340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162015

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -109 lines)			Patch
M	LayoutTests/fast/js/constructor-length.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/js/constructor-length-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/media/track/text-track-cue-constructor.html	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	LayoutTests/media/track/text-track-cue-constructor-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/media/track/track-cues-cuechange-expected.txt	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/media/track/track-cues-enter-exit-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/bindings.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	Source/bindings/v8/custom/V8TextTrackCueCustom.cpp	View	1 chunk	+25 lines, -28 lines	0 comments	Download
M	Source/core/core.gypi	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/html/track/InbandTextTrack.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/track/LoadableTextTrack.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/track/TextTrackCue.h	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	Source/core/html/track/TextTrackCue.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/track/TextTrackCue.idl	View	2 chunks	+3 lines, -15 lines	0 comments	Download
A +	Source/core/html/track/VTTCue.h	View	1 chunk	+14 lines, -25 lines	0 comments	Download
A +	Source/core/html/track/VTTCue.cpp	View	1 chunk	+15 lines, -6 lines	0 comments	Download
A +	Source/core/html/track/VTTCue.idl	View	1 chunk	+15 lines, -8 lines	0 comments	Download
M	Source/core/html/track/WebVTTParser.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/track/WebVTTParser.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/loader/TextTrackLoader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/TextTrackLoader.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Part 1: this review Part 2: https://codereview.chromium.org/72543003/

7 years, 1 month ago (2013-11-14 08:52:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/63173020/1

7 years, 1 month ago (2013-11-14 12:04:45 UTC) #3

Message was sent while issue was closed.

Change committed as 162015

Expand Messages | Collapse Messages