chrome/browser/devtools/devtools_embedder_message_dispatcher.h - Issue 63173016: DevTools: place DevTools WebContents underneath inspected WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_embedder_message_dispatcher.h

Issue 63173016: DevTools: place DevTools WebContents underneath inspected WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the preference. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_embedder_message_dispatcher.h

diff --git a/chrome/browser/devtools/devtools_embedder_message_dispatcher.h b/chrome/browser/devtools/devtools_embedder_message_dispatcher.h

index 8cf996fef52925e0f91c208cc789c0899b7994c0..826983f28bb9c299b6eb1e93b6f566365ce7b711 100644

--- a/chrome/browser/devtools/devtools_embedder_message_dispatcher.h

+++ b/chrome/browser/devtools/devtools_embedder_message_dispatcher.h

@@ -28,7 +28,8 @@ class DevToolsEmbedderMessageDispatcher {

virtual void ActivateWindow() = 0;

virtual void CloseWindow() = 0;

- virtual void SetWindowBounds(int x, int y, int width, int height) = 0;

+ virtual void SetContentsOffsets(

pfeldman 2013/11/18 14:18:27 I'd do SetContentsRect(x, y, width, height)

+ int left, int top, int right, int bottom) = 0;

virtual void MoveWindow(int x, int y) = 0;

virtual void SetDockSide(const std::string& side) = 0;

virtual void OpenInNewTab(const std::string& url) = 0;

« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_embedder_message_dispatcher.cc » ('j') | chrome/browser/devtools/devtools_window.h » ('J')