Issue 63173014: More new baselines for stragglerbots.

Issue 63173014: More new baselines for stragglerbots. (Closed)

Created:
7 years, 1 month ago by Stephen White

Modified:
7 years, 1 month ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

More new baselines for stragglerbots. TBR=epoger BUG= Committed: https://code.google.com/p/skia/source/detail?r=12207

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -18 lines)			Patch
M	expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json	View	11 chunks	+11 lines, -11 lines	0 comments	Download
M	expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json	View	1 chunk	+1 line, -1 line	1 comment	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Committed patchset #1 manually as r12207 (presubmit successful).

7 years, 1 month ago (2013-11-09 04:45:25 UTC) #1

epoger

https://codereview.chromium.org/63173014/diff/1/expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json File expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json (right): https://codereview.chromium.org/63173014/diff/1/expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json#newcode4627 expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json:4627: 592324931029193071 I see that this is the image change ...

7 years, 1 month ago (2013-11-10 01:53:49 UTC) #2

epoger

7 years, 1 month ago (2013-11-10 02:28:21 UTC) #3

Message was sent while issue was closed.

LGTM (rubberstamp, don't have a good way of viewing the diffs)

On 2013/11/10 01:53:49, epoger wrote:
>
https://codereview.chromium.org/63173014/diff/1/expectations/gm/Test-Ubuntu13...
> File
>
expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json
> (right):
> 
>
https://codereview.chromium.org/63173014/diff/1/expectations/gm/Test-Ubuntu13...
>
expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json:4627:
> 592324931029193071
> I see that this is the image change referred to by
> https://code.google.com/p/skia/issues/detail?id=1824 ('dashing3_gpu
> ExpectationsMismatch on Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN').
> 
> Do we have some reason to expect this change?  Is the new image better (or at
> least not worse) than the old one?

Actually, as noted in bug 1824, we don't really care about the ASAN gm results,
so we don't need to worry about that particular test.  I'm just trying to make
sure we understand GM failures, and aren't just checking in new expectations
blind.

Expand Messages | Collapse Messages