Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 631703002: Use the pnacl-clang toolchain for (P)NaCL builds (Closed)

Created:
6 years, 2 months ago by Sven Panne
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use the pnacl-clang toolchain for (P)NaCL builds Patch from JF Bastien <jfb@google.com>;. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -44 lines) Patch
M Makefile.nacl View 3 chunks +16 lines, -23 lines 0 comments Download
M src/base/atomicops.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/base/build_config.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +13 lines, -5 lines 0 comments Download
M tools/nacl-run.py View 4 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 2 months ago (2014-10-06 08:08:25 UTC) #2
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-06 08:09:30 UTC) #3
Sven Panne
6 years, 2 months ago (2014-10-06 08:11:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698