Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 631683002: Replacing the OVERRIDE with override in /src/pdf (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, jam
CC:
chromium-reviews, MRV, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override in /src/pdf This step is a giant search and replace for OVERRIDE to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/4e34259440bf1733069a54eece6bca75c1340947 Cr-Commit-Position: refs/heads/master@{#299056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M pdf/instance.h View 2 chunks +21 lines, -21 lines 0 comments Download
M pdf/out_of_process_instance.h View 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 07:51:39 UTC) #2
anujsharma
On 2014/10/06 07:51:39, anujsharma wrote: > PTAL @Jam, Could you please give thumbs up for ...
6 years, 2 months ago (2014-10-09 14:30:13 UTC) #3
anujsharma
On 2014/10/09 14:30:13, anujsharma wrote: > On 2014/10/06 07:51:39, anujsharma wrote: > > PTAL > ...
6 years, 2 months ago (2014-10-10 03:00:43 UTC) #5
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-10 03:28:21 UTC) #6
anujsharma
On 2014/10/10 03:28:21, Lei Zhang wrote: > lgtm Thanks Lei for lgtm.
6 years, 2 months ago (2014-10-10 03:28:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631683002/1
6 years, 2 months ago (2014-10-10 03:30:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 04:23:13 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 04:23:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e34259440bf1733069a54eece6bca75c1340947
Cr-Commit-Position: refs/heads/master@{#299056}

Powered by Google App Engine
This is Rietveld 408576698