Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 631593003: Add lsof to chroot. (Closed)

Created:
6 years, 2 months ago by Yoshisato Yanagisawa
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add lsof to chroot. BUG=409482 NOTRY=true Committed: https://crrev.com/9061716adeebd331494cf8a1d473302f3d303066 Cr-Commit-Position: refs/heads/master@{#298662}

Patch Set 1 #

Total comments: 2

Patch Set 2 : to alphabetical order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-chroot.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Yoshisato Yanagisawa
let me add lsof to chroot'ed env. It should be useful for running goma.
6 years, 2 months ago (2014-10-08 05:16:22 UTC) #2
Lei Zhang
lgtm Thanks for the quick fix. You can also add NOTRY=true to the commit message ...
6 years, 2 months ago (2014-10-08 05:22:23 UTC) #3
Yoshisato Yanagisawa
Thanks for the review. https://codereview.chromium.org/631593003/diff/1/build/install-chroot.sh File build/install-chroot.sh (right): https://codereview.chromium.org/631593003/diff/1/build/install-chroot.sh#newcode642 build/install-chroot.sh:642: strace lsof On 2014/10/08 05:22:23, ...
6 years, 2 months ago (2014-10-08 05:31:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631593003/20001
6 years, 2 months ago (2014-10-08 06:20:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c5cdbb215d44d27f232394d59d182ade77b836f4
6 years, 2 months ago (2014-10-08 06:25:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 06:26:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9061716adeebd331494cf8a1d473302f3d303066
Cr-Commit-Position: refs/heads/master@{#298662}

Powered by Google App Engine
This is Rietveld 408576698