Source/devtools/front_end/timeline/TimelinePanel.js - Issue 631573002: [Devtools] Replace "Stacks" with "Causes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 631573002: [Devtools] Replace "Stacks" with "Causes" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update per reviewer comments, and remove the causes tab Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/timeline/TimelineModelImpl.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js

index 3123606d92cfc4857d6b5e4f98fb39212ac44ef6..5bb826c9db8a51dd9e41416bdd1ba57943c4528c 100644

--- a/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -347,11 +347,11 @@ WebInspector.TimelinePanel.prototype = {

panelStatusBarElement.appendChild(flameChartToggleButton.element);

}

- this._captureStacksSetting = WebInspector.settings.createSetting("timelineCaptureStacks", true);

- this._captureStacksSetting.addChangeListener(this._refreshViews, this);

- panelStatusBarElement.appendChild(this._createSettingCheckbox(WebInspector.UIString("Stacks"),

- this._captureStacksSetting,

- WebInspector.UIString("Capture JavaScript stack on every timeline event")));

+ this._captureCausesSetting = WebInspector.settings.createSetting("timelineCaptureCauses", true);

+ this._captureCausesSetting.addChangeListener(this._refreshViews, this);

+ panelStatusBarElement.appendChild(this._createSettingCheckbox(WebInspector.UIString("Causes"),

+ this._captureCausesSetting,

+ WebInspector.UIString("Capture causes for timeline events (e.g., stack traces)")));

this._captureMemorySetting = WebInspector.settings.createSetting("timelineCaptureMemory", false);

panelStatusBarElement.appendChild(this._createSettingCheckbox(WebInspector.UIString("Memory"),

this._captureMemorySetting,

@@ -639,7 +639,7 @@ WebInspector.TimelinePanel.prototype = {

_startRecording: function(userInitiated)

{

this._userInitiatedRecording = userInitiated;

- this._model.startRecording(this._captureStacksSetting.get(), this._captureMemorySetting.get(), this._captureLayersAndPicturesSetting && this._captureLayersAndPicturesSetting.get());

+ this._model.startRecording(this._captureCausesSetting.get(), this._captureMemorySetting.get(), this._captureLayersAndPicturesSetting && this._captureLayersAndPicturesSetting.get());

if (this._lazyFrameModel)

this._lazyFrameModel.setMergeRecords(false);