Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 631573002: [Devtools] Replace "Stacks" with "Causes" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update per reviewer comments, and remove the causes tab Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index f678352f84de7bbfdfa6179bc2f4c6f926d51459..0840f8303d68942df03d6639663cd5662ba319fd 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -42,7 +42,7 @@ WebInspector.TimelineFlameChartDataProvider = function(model, frameModel)
this._frameModel = frameModel;
this._font = "12px " + WebInspector.fontFamily();
this._linkifier = new WebInspector.Linkifier();
- this._captureStacksSetting = WebInspector.settings.createSetting("timelineCaptureStacks", true);
+ this._captureCausesSetting = WebInspector.settings.createSetting("timelineCaptureCauses", true);
this._filters = [];
this.addFilter(WebInspector.TracingTimelineUIUtils.hiddenEventsFilter());
this.addFilter(new WebInspector.TracingTimelineModel.ExclusiveEventNameFilter([WebInspector.TracingTimelineModel.RecordType.Program]));
@@ -198,7 +198,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
{
var levelCount = this._appendAsyncEvents(threadTitle, asyncEvents);
if (Runtime.experiments.isEnabled("timelineJSCPUProfile")) {
- if (this._captureStacksSetting.get()) {
+ if (this._captureCausesSetting.get()) {
var jsFrameEvents = this._generateJSFrameEvents(syncEvents);
syncEvents = jsFrameEvents.mergeOrdered(syncEvents, WebInspector.TracingModel.Event.orderedCompareStartTime);
}
« no previous file with comments | « LayoutTests/inspector/tracing/timeline-event-causes-expected.txt ('k') | Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698