pkg/analysis_server/test/integration/server/status_test.dart - Issue 631553002: Change integration test notifications to use structured objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/server/status_test.dart

Issue 631553002: Change integration test notifications to use structured objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/integration/integration_tests.dart ('k') | pkg/analysis_server/tool/spec/codegen_inttest_methods.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/server/status_test.dart

diff --git a/pkg/analysis_server/test/integration/server/status_test.dart b/pkg/analysis_server/test/integration/server/status_test.dart

index e75727435a4ed752ff36968cc88715427f9d382e..e2ba8259590c3774104d4d125d506b68c2d773e5 100644

--- a/pkg/analysis_server/test/integration/server/status_test.dart

+++ b/pkg/analysis_server/test/integration/server/status_test.dart

@@ -6,9 +6,10 @@ library test.integration.server.status;

import 'dart:async';

-import '../../reflective_tests.dart';

+import 'package:analysis_server/src/protocol.dart';

import 'package:unittest/unittest.dart';

+import '../../reflective_tests.dart';

import '../integration_tests.dart';

@ReflectiveTestCase()

@@ -19,9 +20,9 @@ class Test extends AbstractAnalysisServerIntegrationTest {

// analyzing=false.

Completer analysisBegun = new Completer();

Completer analysisFinished = new Completer();

- onServerStatus.listen((params) {

- if (params['analysis'] != null) {

- if (params['analysis']['isAnalyzing']) {

+ onServerStatus.listen((ServerStatusParams params) {

+ if (params.analysis != null) {

+ if (params.analysis.isAnalyzing) {

expect(analysisBegun.isCompleted, isFalse);

analysisBegun.complete();

} else {