Issue 63153003: mac: Prepare for -Wunused-functions.

Issue 63153003: mac: Prepare for -Wunused-functions. (Closed)

Created:
7 years, 1 month ago by Nico

Modified:
7 years, 1 month ago

Reviewers:
jamesr, sky, Ami GONE FROM CHROMIUM, Lei Zhang, piman, youngki, brettw, Ilya Sherman, akalin

CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, erikwright (departed), sievers+watch_chromium.org, yukishiino+watch_chromium.org, miu+watch_chromium.org, joi+watch-content_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benjhayden+dwatch_chromium.org, jam, apatrick_chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, erikwright+watch_chromium.org, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Prepare for -Wunused-functions. Mostly involves deleting hundreds of lines of unused code. BUG=315884 R=akalin@chromium.org, brettw@chromium.org, fischman@chromium.org, jamesr@chromium.org, sky@chromium.org, thestig@chromium.org TBR=piman, youngki Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233646

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -651 lines)			Patch
M	base/time/time_posix.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	cc/layers/picture_layer_impl.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	cc/resources/tile_priority.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/devtools/adb/android_rsa.cc	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/api/developer_private/developer_private_api.cc	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolbar_model.cc	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_url_generator.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/managed_mode/managed_user_service.cc	View	1	2 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/metrics/thread_watcher.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/metrics/variations/variations_service.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/password_manager/password_syncable_service.cc	View	1	1 chunk	+0 lines, -68 lines	0 comments	Download
M	chrome/browser/policy/browser_policy_connector.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/pepper/pepper_talk_host.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.cc	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	chrome/browser/signin/signin_internals_util.cc	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/storage_monitor/media_storage_util.cc	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View	1 2 3	1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/themes/theme_service.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_service_mac.mm	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller.mm	View	1	2 chunks	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/webui/history_ui.cc	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/webui/options/manage_profile_handler.cc	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/usb/usb_device.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/autofill/core/browser/autofill_manager.cc	View	1 2 3	1 chunk	+0 lines, -10 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_guest.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2 3	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/child/indexed_db/indexed_db_dispatcher.cc	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/child/npapi/plugin_instance_mac.mm	View		1 chunk	+0 lines, -50 lines	0 comments	Download
M	content/child/site_isolation_policy.cc	View	1 2 3	1 chunk	+0 lines, -15 lines	0 comments	Download
M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/renderer/npapi/webplugin_delegate_proxy.cc	View	1 2 3	1 chunk	+0 lines, -8 lines	0 comments	Download
M	device/bluetooth/bluetooth_adapter_factory.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gl_in_process_context.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	media/audio/mac/audio_auhal_mac.cc	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	media/filters/opus_audio_decoder.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	net/cert/ct_serialization.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	net/cert/x509_certificate_mac.cc	View		1 chunk	+0 lines, -54 lines	0 comments	Download
M	net/cookies/cookie_monster.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	net/disk_cache/simple/simple_backend_impl.cc	View		2 chunks	+0 lines, -27 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	tools/gn/input_conversion.cc	View		1 chunk	+0 lines, -28 lines	0 comments	Download
M	tools/gn/parser.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	tools/gn/setup.cc	View		4 chunks	+3 lines, -13 lines	0 comments	Download
M	ui/events/event.cc	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	ui/gfx/canvas_skia.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/gfx/interpolated_transform.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/common/cursors/webcursor_mac.mm	View	1 2 3	1 chunk	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Nico

brettw: base, tools/gn piman: content, gpu jamesr: cc, webkit thestig: chrome akalin: net sky: ui

7 years, 1 month ago (2013-11-07 16:32:20 UTC) #1

jamesr

lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...

7 years, 1 month ago (2013-11-07 17:36:56 UTC) #8

Nico

7 years, 1 month ago (2013-11-07 18:47:30 UTC) #11

Message was sent while issue was closed.

Committed patchset #4 manually as r233646 (presubmit successful).

Expand Messages | Collapse Messages