Copy text selection from renderer to browser every time it changes.

Copy text selection from renderer to browser every time it changes.

BUG=9848
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13396

[Evan Stade, 2009-04-08 23:17:22]

This is solution (d). Anecdotally it doesn't make drag-selecting a huge
document[1] any slower, because it is already painfully slow[2].

[1]3.2 mb of plain text.
[2]By "already", I mean that I disabled selection text copying in the render
view as well as the IPCs, and also tested on windows as well as linux.

[tony, 2009-04-09 00:11:58]

Wow, it really is already painfully slow.

LGTM.

On 2009/04/08 23:17:22, estade wrote:
> This is solution (d). Anecdotally it doesn't make drag-selecting a huge
> document[1] any slower, because it is already painfully slow[2].
> 
> [1]3.2 mb of plain text.
> [2]By "already", I mean that I disabled selection text copying in the render
> view as well as the IPCs, and also tested on windows as well as linux.

[darin (slow to review), 2009-04-09 05:00:27]

LGTM

if this proves to be unbearable, maybe the approach of using SendWithTimeout
should be reconsidered?

http://codereview.chromium.org/63145/diff/1002/18
File chrome/browser/renderer_host/render_widget_host_view.h (right):

http://codereview.chromium.org/63145/diff/1002/18#newcode116
Line 116: virtual void SelectionChanged(const std::string& text) { };
nit: no need for trailing ';'