Issue 63142: Scaffolding cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63142: Scaffolding cleanup. (Closed)

Created:
11 years, 8 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Scaffolding cleanup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13394

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -105 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_state_controller.mm	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_mac.mm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1	4 chunks	+12 lines, -78 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View	1	1 chunk	+7 lines, -27 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 8 months ago (2009-04-08 23:45:54 UTC) #2

cool, LG

http://codereview.chromium.org/63142/diff/6/1008
File chrome/common/temp_scaffolding_stubs.cc (left):

http://codereview.chromium.org/63142/diff/6/1008#oldcode46
Line 46: #include "webkit/glue/webkit_glue.h"
wow nice!

Expand Messages | Collapse Messages