Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 63137: Make the PrintDlgEx() call in the UI thread. (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/printing/printer_query.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_worker.cc
===================================================================
--- chrome/browser/printing/print_job_worker.cc (revision 13415)
+++ chrome/browser/printing/print_job_worker.cc (working copy)
@@ -67,7 +67,12 @@
void PrintJobWorker::GetSettings(bool ask_user_for_settings,
HWND parent_window,
int document_page_count) {
- DCHECK_EQ(message_loop(), MessageLoop::current());
+ if (ask_user_for_settings) {
+ // No way to retrieve the ui (browser) message loop.
+ // DCHECK_EQ(ui_message_loop_, MessageLoop::current());
+ } else {
+ DCHECK_EQ(message_loop(), MessageLoop::current());
+ }
DCHECK_EQ(page_number_, PageNumber::npos());
// Recursive task processing is needed for the dialog in case it needs to be
« no previous file with comments | « no previous file | chrome/browser/printing/printer_query.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698