Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 631363002: Truncate RenderText widths before comparing against bounds. (Closed)

Created:
6 years, 2 months ago by Daniel Erat
Modified:
6 years, 2 months ago
Reviewers:
msw, ckocagil
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Truncate RenderText widths before comparing against bounds. Make RenderText truncate floating-point widths before comparing them against integer display bounds when determining whether text should be elided. RenderTextHarfBuzz returns fractional widths when subpixel positioning is enabled. When rendering omnibox results, these widths typically exceed the integer bounds, resulting in text getting inappropriately elided. BUG=402347 Committed: https://crrev.com/ec562a798a1835e0383e83bae7dc71dffcfc5fb0 Cr-Commit-Position: refs/heads/master@{#298626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ui/gfx/render_text.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Erat
i left a longer comment on the bug. i'd like to add a unit tests ...
6 years, 2 months ago (2014-10-07 22:26:48 UTC) #2
msw
lgtm
6 years, 2 months ago (2014-10-07 22:42:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631363002/1
6 years, 2 months ago (2014-10-07 23:31:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4987c11cb9127a6a99bffafc1564766429488d13
6 years, 2 months ago (2014-10-08 00:57:43 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec562a798a1835e0383e83bae7dc71dffcfc5fb0 Cr-Commit-Position: refs/heads/master@{#298626}
6 years, 2 months ago (2014-10-08 00:59:49 UTC) #7
ckocagil
6 years, 2 months ago (2014-10-10 16:07:22 UTC) #8
Message was sent while issue was closed.
lgtm, thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698