Issue 631353002: Add 4 Variations.SeedDateSkew.* histograms to analyze whether the system clock or the build time co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 631353002: Add 4 Variations.SeedDateSkew.* histograms to analyze whether the system clock or the build time co… (Closed)

Created:
6 years, 2 months ago by robertshield

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

Merging ca7e807424780 to branch 2171. Add 4 Variations.SeedDateSkew.* histograms to analyze whether the system clock or the build time could be used as a long term expiry clock for very old variations seeds. BUG=419622 TBR=gab Review URL: https://codereview.chromium.org/617263007 Cr-Commit-Position: refs/heads/master@{#297841} (cherry picked from commit ca7e80742478074d6f96190c14f9b97e8eeba2ba) Committed: https://chromium.googlesource.com/chromium/src/+/d9eefe954b3dcf7cfc85741843ba8484a8603ea3

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -1 line)			Patch
	M	chrome/browser/metrics/variations/variations_service.cc	View		2 chunks	+30 lines, -1 line	0 comments	Download
	M	tools/metrics/histograms/histograms.xml	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

robertshield

6 years, 2 months ago (2014-10-07 21:51:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d9eefe954b3dcf7cfc85741843ba8484a8603ea3 (presubmit successful).