Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3347)

Unified Diff: athena/extensions/athena_app_window_client_base.cc

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/extensions/athena_app_window_client_base.cc
diff --git a/athena/extensions/athena_app_window_client_base.cc b/athena/extensions/athena_app_window_client_base.cc
index a37d1b2a632c1fa8e5f16531a8321cf97f57716e..fc02fb935220f4c888bd3f9697b90a7d8c093d26 100644
--- a/athena/extensions/athena_app_window_client_base.cc
+++ b/athena/extensions/athena_app_window_client_base.cc
@@ -7,6 +7,8 @@
#include "athena/activity/public/activity_factory.h"
#include "athena/activity/public/activity_manager.h"
#include "athena/extensions/athena_native_app_window_views.h"
+#include "athena/wm/public/window_list_provider.h"
+#include "athena/wm/public/window_manager.h"
#include "extensions/common/extension.h"
namespace athena {
@@ -19,11 +21,23 @@ AthenaAppWindowClientBase::~AthenaAppWindowClientBase() {
extensions::NativeAppWindow* AthenaAppWindowClientBase::CreateNativeAppWindow(
extensions::AppWindow* app_window,
- const extensions::AppWindow::CreateParams& params) {
+ extensions::AppWindow::CreateParams* params) {
AthenaNativeAppWindowViews* native_window = new AthenaNativeAppWindowViews;
- native_window->Init(app_window, params);
+ native_window->Init(app_window, *params);
ActivityFactory::Get()->CreateAppActivity(app_window->extension_id(),
native_window->GetWebView());
+ if (params->focused) {
+ // Windows are created per default at the top of the stack. If - at this
+ // point of initialization - it is has been moved into a different Z-order
+ // location we should respect this, not allowing the application activation
+ // to bring it to the front. This can happen as part of the resource
+ // manager's reloading or intelligent preloading of an application.
+ const aura::Window::Windows& list =
+ WindowManager::Get()->GetWindowListProvider()->GetWindowList();
+ aura::Window* native_app_window =
+ native_window->widget()->GetNativeWindow();
+ params->focused = !list.size() || list.back() == native_app_window;
+ }
return native_window;
}
« no previous file with comments | « athena/extensions/athena_app_window_client_base.h ('k') | chrome/browser/ui/apps/chrome_app_window_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698