athena/content/content_proxy.cc - Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/content/content_proxy.cc

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/content/content_proxy.cc

diff --git a/athena/content/content_proxy.cc b/athena/content/content_proxy.cc

index 121d7ad2011359d78c642deef8a8a667da26dbd9..f2a2f137a9f2c18cd8beef70aeab7493d88c953e 100644

--- a/athena/content/content_proxy.cc

+++ b/athena/content/content_proxy.cc

@@ -144,7 +144,10 @@ void ContentProxy::CreateProxyContent() {

content::RenderViewHost* host =

web_view_->GetWebContents()->GetRenderViewHost();

- DCHECK(host && host->GetView());

+ DCHECK(host);

+ // A never fully initialized content can come here with no view.

+ if (!host->GetView())

+ return;

gfx::Size source = host->GetView()->GetViewBounds().size();

gfx::Size target = gfx::Size(source.width() / 2, source.height() / 2);

host->CopyFromBackingStore(

« no previous file with comments | « athena/content/app_activity_proxy.cc ('k') | athena/extensions/DEPS » ('j') | no next file with comments »