Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2923)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/shell/browser/shell_app_window_client.h

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« athena/content/app_activity.cc ('K') | « extensions/browser/extension_registry.h ('k') | extensions/shell/browser/shell_app_window_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_app_window_client.h
diff --git a/extensions/shell/browser/shell_app_window_client.h b/extensions/shell/browser/shell_app_window_client.h
index 0681cabcdd9edeece567f7d898bd56def9eda7bc..e78a5675d9b57a5de830efde92bf6a1ea34749f6 100644
--- a/extensions/shell/browser/shell_app_window_client.h
+++ b/extensions/shell/browser/shell_app_window_client.h
@@ -22,7 +22,7 @@ class ShellAppWindowClient : public AppWindowClient {
const Extension* extension) override;
virtual NativeAppWindow* CreateNativeAppWindow(
AppWindow* window,
- const AppWindow::CreateParams& params) override;
+ AppWindow::CreateParams* params) override;
virtual void OpenDevToolsWindow(content::WebContents* web_contents,
const base::Closure& callback) override;
virtual bool IsCurrentChannelOlderThanDev() override;
« athena/content/app_activity.cc ('K') | « extensions/browser/extension_registry.h ('k') | extensions/shell/browser/shell_app_window_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698