athena/extensions/athena_app_window_client_base.h - Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/athena_app_window_client_base.h

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/extensions/athena_app_window_client_base.h

diff --git a/athena/extensions/athena_app_window_client_base.h b/athena/extensions/athena_app_window_client_base.h

index e346de9d42e01fb566e9391255f4cb3eb99ef662..00d3a8af8b356111e64c397946c38edfe9cc1ab4 100644

--- a/athena/extensions/athena_app_window_client_base.h

+++ b/athena/extensions/athena_app_window_client_base.h

@@ -20,7 +20,7 @@ class AthenaAppWindowClientBase : public extensions::AppWindowClient {

// extensions::AppWindowClient

virtual extensions::NativeAppWindow* CreateNativeAppWindow(

extensions::AppWindow* window,

- const extensions::AppWindow::CreateParams& params) override;

+ extensions::AppWindow::CreateParams* params) override;

DISALLOW_COPY_AND_ASSIGN(AthenaAppWindowClientBase);

};

« athena/content/app_activity.cc ('K') | « athena/extensions/DEPS ('k') | athena/extensions/athena_app_window_client_base.cc » ('j') | no next file with comments »