Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 63133002: Get rid of custom constructor for FormData (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Get rid of custom constructor for FormData Get rid of custom constructor for FormData and let the generator produces its code instead. There does not appear to be any difference between the custom code and the generated one. R=haraken TEST=http/tests/local/formdata Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/bindings/v8/custom/V8FormDataCustom.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/FormData.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
For comparison, the generated code looks like: V8TRYCATCH_VOID(HTMLFormElement*, form, V8HTMLFormElement::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8HTMLFormElement::toNative(v8::Handle<v8::Object>::Cast(info[0])) : ...
7 years, 1 month ago (2013-11-06 20:57:37 UTC) #1
haraken
LGTM
7 years, 1 month ago (2013-11-07 00:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/63133002/1
7 years, 1 month ago (2013-11-07 01:23:47 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 06:23:40 UTC) #4
Message was sent while issue was closed.
Change committed as 161498

Powered by Google App Engine
This is Rietveld 408576698