Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 631313003: Remove implicit conversions from scoped_refptr to T* in android_webview/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
mkosiba (inactive)
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in android_webview/ Manual fixups for cases the automated tooling elected to skip. BUG=110610 Committed: https://crrev.com/46256f8d8aa293e87c9d524fbf16b8846a1d203d Cr-Commit-Position: refs/heads/master@{#298731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Note that in this case, the callback takes a raw pointer anyway, so constructing a ...
6 years, 2 months ago (2014-10-07 22:14:03 UTC) #2
mkosiba (inactive)
lgtm
6 years, 2 months ago (2014-10-08 10:47:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631313003/1
6 years, 2 months ago (2014-10-08 16:23:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as dde5f63ff5823357aec52e4ede4216990ccd058c
6 years, 2 months ago (2014-10-08 16:47:05 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 16:47:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46256f8d8aa293e87c9d524fbf16b8846a1d203d
Cr-Commit-Position: refs/heads/master@{#298731}

Powered by Google App Engine
This is Rietveld 408576698