Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 63127: Print times for individual tests that take longer than 1 second to run. (Closed)

Created:
11 years, 8 months ago by ojan
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Print times for individual tests that take longer than 1 second to run. On my quad-core mac, this was <100 tests. I'm hoping we can gather some data for implementing bug 9324.

Patch Set 1 #

Patch Set 2 : Made us spit out top 50 slowest tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M webkit/tools/layout_tests/layout_package/test_shell_thread.py View 3 chunks +14 lines, -3 lines 0 comments Download
M webkit/tools/layout_tests/run_webkit_tests.py View 1 5 chunks +22 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
ojan
11 years, 8 months ago (2009-04-08 18:26:01 UTC) #1
tony
LG. Maybe we should limit the output to ~100 of the slowest tests?
11 years, 8 months ago (2009-04-08 18:34:02 UTC) #2
ojan
Changed it to not look at the time at all and to just print the ...
11 years, 8 months ago (2009-04-08 19:22:47 UTC) #3
tony
11 years, 8 months ago (2009-04-08 19:33:19 UTC) #4
LGTM

http://codereview.chromium.org/63127/diff/1001/1003
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/63127/diff/1001/1003#newcode549
Line 549: slowests_tests = \
Nit: Normally in python code we use () to get implicit line continuation.  E.g.,
slowest_tests = (
     blah blah   )

Powered by Google App Engine
This is Rietveld 408576698