Issue 63127: Print times for individual tests that take longer than 1 second to run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63127: Print times for individual tests that take longer than 1 second to run. (Closed)

Created:
11 years, 8 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Print times for individual tests that take longer than 1 second to run. On my quad-core mac, this was <100 tests. I'm hoping we can gather some data for implementing bug 9324.

Patch Set 1 #

Patch Set 2 : Made us spit out top 50 slowest tests #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -5 lines)			Patch
	M	webkit/tools/layout_tests/layout_package/test_shell_thread.py	View		3 chunks	+14 lines, -3 lines	0 comments	Download
	M	webkit/tools/layout_tests/run_webkit_tests.py	View	1	5 chunks	+22 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LG. Maybe we should limit the output to ~100 of the slowest tests?

11 years, 8 months ago (2009-04-08 18:34:02 UTC) #2

ojan

Changed it to not look at the time at all and to just print the ...

11 years, 8 months ago (2009-04-08 19:22:47 UTC) #3

tony

11 years, 8 months ago (2009-04-08 19:33:19 UTC) #4

LGTM

http://codereview.chromium.org/63127/diff/1001/1003
File webkit/tools/layout_tests/run_webkit_tests.py (right):

http://codereview.chromium.org/63127/diff/1001/1003#newcode549
Line 549: slowests_tests = \
Nit: Normally in python code we use () to get implicit line continuation.  E.g.,
slowest_tests = (
     blah blah   )

Expand Messages | Collapse Messages