chrome/browser/history/chrome_history_client_factory.h - Issue 631253002: Refactor sending NOTIFICATION_HISTORY_URL_VISITED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/chrome_history_client_factory.h

Issue 631253002: Refactor sending NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests on Android Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/chrome_history_client_factory.h

diff --git a/chrome/browser/history/chrome_history_client_factory.h b/chrome/browser/history/chrome_history_client_factory.h

index 28adc7ee432e92c2ebbbf77e798ff904071ae7d0..01eb7f479890c9cfe7b2fe19c5a70b55abe84320 100644

--- a/chrome/browser/history/chrome_history_client_factory.h

+++ b/chrome/browser/history/chrome_history_client_factory.h

@@ -19,6 +19,11 @@ class ChromeHistoryClientFactory : public BrowserContextKeyedServiceFactory {

public:

static ChromeHistoryClient* GetForProfile(Profile* profile);

+ // TODO(sdefresne): remove this once ChromeHistoryClient is no longer an

+ // HistoryServiceObserver and can follow the regular shutdown even during

+ // tests.

+ static ChromeHistoryClient* GetForProfileWithoutCreating(Profile* profile);

static ChromeHistoryClientFactory* GetInstance();

private: