Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4064)

Unified Diff: chrome/browser/history/in_memory_url_index_unittest.cc

Issue 631253002: Refactor sending NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/in_memory_url_index_unittest.cc
diff --git a/chrome/browser/history/in_memory_url_index_unittest.cc b/chrome/browser/history/in_memory_url_index_unittest.cc
index b721d2a1507d8dbc113e59437314234af3401233..0a0ee7a1b0ead7aa21426d9a59980c70f687e4ef 100644
--- a/chrome/browser/history/in_memory_url_index_unittest.cc
+++ b/chrome/browser/history/in_memory_url_index_unittest.cc
@@ -287,9 +287,11 @@ void InMemoryURLIndexTest::SetUp() {
transaction.Commit();
}
- url_index_.reset(new InMemoryURLIndex(
- &profile_, base::FilePath(), "en,ja,hi,zh",
- history_service_->history_client()));
+ url_index_.reset(new InMemoryURLIndex(&profile_,
+ history_service_,
+ base::FilePath(),
+ "en,ja,hi,zh",
+ history_service_->history_client()));
url_index_->Init();
url_index_->RebuildFromHistory(history_database_);
}
@@ -446,9 +448,11 @@ TEST_F(LimitedInMemoryURLIndexTest, Initialization) {
uint64 row_count = 0;
while (statement.Step()) ++row_count;
EXPECT_EQ(1U, row_count);
- url_index_.reset(new InMemoryURLIndex(
- &profile_, base::FilePath(), "en,ja,hi,zh",
- history_service_->history_client()));
+ url_index_.reset(new InMemoryURLIndex(&profile_,
+ history_service_,
+ base::FilePath(),
+ "en,ja,hi,zh",
+ history_service_->history_client()));
url_index_->Init();
url_index_->RebuildFromHistory(history_database_);
URLIndexPrivateData& private_data(*GetPrivateData());
@@ -1200,7 +1204,7 @@ void InMemoryURLIndexCacheTest::SetUp() {
HistoryClient history_client;
base::FilePath path(temp_dir_.path());
url_index_.reset(new InMemoryURLIndex(
- NULL, path, "en,ja,hi,zh", &history_client));
+ NULL, nullptr, path, "en,ja,hi,zh", &history_client));
}
void InMemoryURLIndexCacheTest::set_history_dir(

Powered by Google App Engine
This is Rietveld 408576698