Refactor sending NOTIFICATION_HISTORY_URL_VISITED

chrome/browser/history/history_backend.h

Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index b6ac8b946164078a064b44b578274b0ae3f8e53c..ae069cc883407009e0484614ab5b0ed184031b32 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -124,6 +124,13 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
     // the events to the FaviconChangedObservers in the correct thread.
     virtual void NotifyFaviconChanged(const std::set<GURL>& urls) = 0;
 
+    // Notify HistoryService that the user is visiting an URL. The event will
+    // be forwarded to the HistoryServiceObservers in the correct thread.
+    virtual void NotifyURLVisited(ui::PageTransition transition,
+                                  const URLRow& row,
+                                  const RedirectList& redirects,
+                                  const base::Time& visit_time) = 0;

[brettw, 2014/10/07 16:47:39]

I usually pass times by copy, since a time is really an int64 and copying is
usually cheaper than dereferencing the reference. You can keep it this way if
you really like, though.

[sdefresne, 2014/10/09 09:38:15]

Apparently not using const reference is the most common pattern. Done.

$ git grep 'const base::Time&' | wc -l
    1057
$ git grep 'base::Time' | grep -v 'const base::Time&' | wc -l
   21682

+
     // Broadcasts the specified notification to the notification service.
     // This is implemented here because notifications must only be sent from
     // the main thread. This is the only method that doesn't identify the