Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/history/history_unittest.cc

Issue 631253002: Refactor sending NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests on Android Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // History unit tests come in two flavors: 5 // History unit tests come in two flavors:
6 // 6 //
7 // 1. The more complicated style is that the unit test creates a full history 7 // 1. The more complicated style is that the unit test creates a full history
8 // service. This spawns a background thread for the history backend, and 8 // service. This spawns a background thread for the history backend, and
9 // all communication is asynchronous. This is useful for testing more 9 // all communication is asynchronous. This is useful for testing more
10 // complicated things or end-to-end behavior. 10 // complicated things or end-to-end behavior.
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 public: 91 public:
92 explicit BackendDelegate(HistoryBackendDBTest* history_test) 92 explicit BackendDelegate(HistoryBackendDBTest* history_test)
93 : history_test_(history_test) { 93 : history_test_(history_test) {
94 } 94 }
95 95
96 virtual void NotifyProfileError(sql::InitStatus init_status) override {} 96 virtual void NotifyProfileError(sql::InitStatus init_status) override {}
97 virtual void SetInMemoryBackend( 97 virtual void SetInMemoryBackend(
98 scoped_ptr<InMemoryHistoryBackend> backend) override; 98 scoped_ptr<InMemoryHistoryBackend> backend) override;
99 virtual void NotifyAddVisit(const BriefVisitInfo& info) override {} 99 virtual void NotifyAddVisit(const BriefVisitInfo& info) override {}
100 virtual void NotifyFaviconChanged(const std::set<GURL>& url) override {} 100 virtual void NotifyFaviconChanged(const std::set<GURL>& url) override {}
101 virtual void NotifyURLVisited(ui::PageTransition transition,
102 const URLRow& row,
103 const RedirectList& redirects,
104 base::Time visit_time) override {}
101 virtual void BroadcastNotifications( 105 virtual void BroadcastNotifications(
102 int type, 106 int type,
103 scoped_ptr<HistoryDetails> details) override; 107 scoped_ptr<HistoryDetails> details) override;
104 virtual void DBLoaded() override {} 108 virtual void DBLoaded() override {}
105 109
106 private: 110 private:
107 HistoryBackendDBTest* history_test_; 111 HistoryBackendDBTest* history_test_;
108 }; 112 };
109 113
110 // This must be outside the anonymous namespace for the friend statement in 114 // This must be outside the anonymous namespace for the friend statement in
(...skipping 1755 matching lines...) Expand 10 before | Expand all | Expand 10 after
1866 std::vector<PageUsageData*> results; 1870 std::vector<PageUsageData*> results;
1867 db_->QuerySegmentUsage(segment_time, 10, &results); 1871 db_->QuerySegmentUsage(segment_time, 10, &results);
1868 ASSERT_EQ(1u, results.size()); 1872 ASSERT_EQ(1u, results.size());
1869 EXPECT_EQ(url, results[0]->GetURL()); 1873 EXPECT_EQ(url, results[0]->GetURL());
1870 EXPECT_EQ(segment_id, results[0]->GetID()); 1874 EXPECT_EQ(segment_id, results[0]->GetID());
1871 EXPECT_EQ(title, results[0]->GetTitle()); 1875 EXPECT_EQ(title, results[0]->GetTitle());
1872 STLDeleteElements(&results); 1876 STLDeleteElements(&results);
1873 } 1877 }
1874 1878
1875 } // namespace history 1879 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/history_service_factory.cc ('k') | chrome/browser/history/in_memory_history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698