Refactor sending NOTIFICATION_HISTORY_URL_VISITED

chrome/browser/history/history_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
 
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 106 matching lines @@
     //
     // This function is NOT guaranteed to be called. If there is an error,
     // there may be no in-memory database.
     virtual void SetInMemoryBackend(
         scoped_ptr<InMemoryHistoryBackend> backend) = 0;
 
     // Notify HistoryService that some URLs favicon changed that will forward
     // the events to the FaviconChangedObservers in the correct thread.
     virtual void NotifyFaviconChanged(const std::set<GURL>& urls) = 0;
 
+    // Notify HistoryService that the user is visiting an URL. The event will
+    // be forwarded to the HistoryServiceObservers in the correct thread.
+    virtual void NotifyURLVisited(ui::PageTransition transition,
+                                  const URLRow& row,
+                                  const RedirectList& redirects,
+                                  const base::Time& visit_time) = 0;

[brettw, 2014/10/07 16:47:39]

I usually pass times by copy, since a time is really an int64 and copying is
usually cheaper than dereferencing the reference. You can keep it this way if
you really like, though.

[sdefresne, 2014/10/09 09:38:15]

Apparently not using const reference is the most common pattern. Done.

$ git grep 'const base::Time&' | wc -l
    1057
$ git grep 'base::Time' | grep -v 'const base::Time&' | wc -l
   21682

+
     // Broadcasts the specified notification to the notification service.
     // This is implemented here because notifications must only be sent from
     // the main thread. This is the only method that doesn't identify the
     // caller because notifications must always be sent.
     virtual void BroadcastNotifications(int type,
                                         scoped_ptr<HistoryDetails> details) = 0;
 
     // Invoked when the backend has finished loading the db.
     virtual void DBLoaded() = 0;
 
@@ skipping 755 matching lines @@
 
   // Listens for the system being under memory pressure.
   scoped_ptr<base::MemoryPressureListener> memory_pressure_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_