Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: grit/format/policy_templates/writers/plist_writer.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« grit/format/policy_templates/writers/plist_strings_writer.py ('K') | « grit/format/policy_templates/writers/plist_strings_writer_unittest.py ('k') | grit/format/policy_templates/writers/reg_writer.py » ('j') | grit/format/policy_templates/writers/reg_writer.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/format/policy_templates/writers/plist_writer.py
===================================================================
--- grit/format/policy_templates/writers/plist_writer.py (revision 177)
+++ grit/format/policy_templates/writers/plist_writer.py (working copy)
@@ -120,7 +120,9 @@
def BeginTemplate(self):
self._plist.attributes['version'] = '1'
dict = self.AddElement(self._plist, 'dict')
-
+ if self._GetChromiumVersionString() is not None:
+ self.AddComment(self._plist, self.config['build'] + ' version: ' + \
+ self._GetChromiumVersionString())
Joao da Silva 2014/10/13 10:30:58 Can you add a unittest for this writer too?
cschuet (SLOW) 2014/10/14 18:55:20 Done.
app_name = plist_helper.GetPlistFriendlyName(self.config['app_name'])
self._AddStringKeyValuePair(dict, 'pfm_name', app_name)
self._AddStringKeyValuePair(dict, 'pfm_description', '')
« grit/format/policy_templates/writers/plist_strings_writer.py ('K') | « grit/format/policy_templates/writers/plist_strings_writer_unittest.py ('k') | grit/format/policy_templates/writers/reg_writer.py » ('j') | grit/format/policy_templates/writers/reg_writer.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698