Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: grit/format/policy_templates/writers/adm_writer_unittest.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/adm_writer_unittest.py
===================================================================
--- grit/format/policy_templates/writers/adm_writer_unittest.py (revision 177)
+++ grit/format/policy_templates/writers/adm_writer_unittest.py (working copy)
@@ -76,6 +76,42 @@
chromium_recommended="Chromium - Recommended"''')
self.CompareOutputs(output, expected_output)
+ def testVersionAnnotation(self):
+ # Test PListWriter in case of empty polices.
+ grd = self.PrepareTest('''
+ {
+ 'policy_definitions': [],
+ 'placeholders': [],
+ 'messages': {
+ 'win_supported_winxpsp2': {
+ 'text': 'At least "Windows 3.11', 'desc': 'blah'
+ },
+ 'doc_recommended': {
+ 'text': 'Recommended', 'desc': 'bleh'
+ }
+ }
+ }''')
+ output = self.GetOutput(grd, 'fr', {'_chromium': '1', 'version':'39.0.0.0'},
pastarmovj 2014/10/07 15:47:16 Move all params to the new line.
cschuet1 2014/10/07 16:00:23 Done.
+ 'adm', 'en')
+ expected_output = '; chromium version: 39.0.0.0\n' +\
pastarmovj 2014/10/07 15:47:16 A space after +.
cschuet1 2014/10/07 16:00:23 Done.
+ self.ConstructOutput(['MACHINE', 'USER'], '''
+ CATEGORY !!chromium
+ KEYNAME "Software\\Policies\\Chromium"
+
+ END CATEGORY
+
+ CATEGORY !!chromium_recommended
+ KEYNAME "Software\\Policies\\Chromium\\Recommended"
+
+ END CATEGORY
+
+
+''', '''[Strings]
+SUPPORTED_WINXPSP2="At least "Windows 3.11"
+chromium="Chromium"
+chromium_recommended="Chromium - Recommended"''')
+ self.CompareOutputs(output, expected_output)
+
def testMainPolicy(self):
# Tests a policy group with a single policy of type 'main'.
grd = self.PrepareTest('''

Powered by Google App Engine
This is Rietveld 408576698