Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Unified Diff: grit/format/policy_templates/writers/reg_writer.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/reg_writer.py
===================================================================
--- grit/format/policy_templates/writers/reg_writer.py (revision 177)
+++ grit/format/policy_templates/writers/reg_writer.py (working copy)
@@ -82,6 +82,9 @@
list.append('"%s"=%s' % (policy['name'], example_value_str))
+ def WriteComment(self, comment):
+ self._prefix.append('; ' + comment)
+
def WritePolicy(self, policy):
if self.CanBeMandatory(policy):
self._WritePolicy(policy,
@@ -103,8 +106,12 @@
self._mandatory = []
self._recommended = []
self._last_key = {}
+ self._prefix = []
def GetTemplateText(self):
- prefix = ['Windows Registry Editor Version 5.00']
- all = prefix + self._mandatory + self._recommended
+ self._prefix.append('Windows Registry Editor Version 5.00')
+ if self._GetChromiumVersionString() is not None:
+ self.WriteComment(self.config['build'] + ' version: ' + \
+ self._GetChromiumVersionString())
+ all = self._prefix + self._mandatory + self._recommended
return self.NEWLINE.join(all)

Powered by Google App Engine
This is Rietveld 408576698