grit/format/policy_templates/writers/adml_writer.py - Issue 631223003: Include chromium version number in policy templates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/adml_writer.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: grit/format/policy_templates/writers/adml_writer.py

===================================================================

--- grit/format/policy_templates/writers/adml_writer.py (revision 177)

+++ grit/format/policy_templates/writers/adml_writer.py (working copy)

@@ -161,6 +161,9 @@

dom_impl = minidom.getDOMImplementation('')

self._doc = dom_impl.createDocument(None, 'policyDefinitionResources',

None)

+ if self._GetChromiumVersionString() is not None:

+ self.AddComment(self._doc.documentElement, self.config['build'] + ''' version: ''' + self._GetChromiumVersionString())

pastarmovj 2014/10/07 14:54:35 Line too long. You don't need triple ''' for one l

cschuet1 2014/10/07 15:42:45 Done.

+ # self.WriteComment(self.config['build'] + ''' version: ''' + self._GetChromiumVersionString())

pastarmovj 2014/10/07 14:54:35 Why is this line here? If you don't need it remove

cschuet1 2014/10/07 15:42:45 Done.

policy_definitions_resources_elem = self._doc.documentElement

policy_definitions_resources_elem.attributes['revision'] = '1.0'

policy_definitions_resources_elem.attributes['schemaVersion'] = '1.0'