Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: grit/format/policy_templates/writers/adm_writer.py

Issue 631223003: Include chromium version number in policy templates (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: grit/format/policy_templates/writers/adm_writer.py
===================================================================
--- grit/format/policy_templates/writers/adm_writer.py (revision 177)
+++ grit/format/policy_templates/writers/adm_writer.py (working copy)
@@ -152,6 +152,9 @@
builder.AddLine('END POLICY', -1)
builder.AddLine()
+ def WriteComment(self, comment):
+ self.lines.AddLine('''; ''' + comment)
+
def WritePolicy(self, policy):
if self.CanBeMandatory(policy):
self._WritePolicy(policy,
@@ -205,6 +208,8 @@
return lines
def BeginTemplate(self):
+ if self._GetChromiumVersionString() is not None:
+ self.WriteComment(self.config['build'] + ''' version: ''' + self._GetChromiumVersionString())
pastarmovj 2014/10/07 14:54:35 nit: Line too long. Split it. 80chars max. No need
cschuet1 2014/10/07 15:42:45 Done.
self._AddGuiString(self.config['win_supported_os'],
self.messages['win_supported_winxpsp2']['text'])
category_path = self.config['win_mandatory_category_path']

Powered by Google App Engine
This is Rietveld 408576698