Include chromium version number in policy templates

grit/format/policy_templates/writers/template_writer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import os

[Joao da Silva, 2014/10/13 10:30:58]

This isn't used

[cschuet (SLOW), 2014/10/14 18:55:20]

Done.

 
 class TemplateWriter(object):
   '''Abstract base class for writing policy templates in various formats.
   The methods of this class will be called by PolicyTemplateGenerator.
   '''
 
   def __init__(self, platforms, config):
     '''Initializes a TemplateWriter object.
 
     Args:
@@ skipping 79 matching lines @@
     '''Checks if |policy| is supported on |platform|.
 
     Args:
       policy: The dictionary of the policy.
       platform: The platform to check; one of 'win', 'mac', 'linux' or
         'chrome_os'.
     '''
     is_supported = lambda x: platform in x['platforms']
     return any(filter(is_supported, policy['supported_on']))
 
+  def _GetChromiumVersionString(self):
+    '''Returns the Chromium version string stored in the environment variable
+    version (if it is set).
+
+    Returns: The Chromium version string or an empty string if it has not

[Joao da Silva, 2014/10/13 10:30:58]

Note that python functions return None by default, so this won't return an empty
string if the version is not set

[cschuet (SLOW), 2014/10/14 18:55:20]

This was the way I originally implemented this. But I switched to returning None
for clarity. Updated the documetation comment.

+             been set.'''
+
+    if 'version' in self.config:
+      return self.config['version']
+
   def _GetPoliciesForWriter(self, group):
     '''Filters the list of policies in the passed group that are supported by
     the writer.
 
     Args:
       group: The dictionary of the policy group.
 
     Returns: The list of policies of the policy group that are compatible
       with the writer.
     '''
@@ skipping 69 matching lines @@
 
   def WritePolicy(self, policy):
     '''Appends the template text corresponding to a policy into the
     internal buffer.
 
     Args:
       policy: The policy as it is found in the JSON file.
     '''
     raise NotImplementedError()
 
+  def WriteComment(self, comment):
+    '''Appends the comment to the internal buffer.                                                                                                                          

[Joao da Silva, 2014/10/13 10:30:58]

Remove trailing whitespaces from this line.

[cschuet (SLOW), 2014/10/14 18:55:20]

Done.

+
+      comment: The comment to be added.                                                                                     

[Joao da Silva, 2014/10/13 10:30:58]

From this one too

[cschuet (SLOW), 2014/10/14 18:55:20]

Done.

+    '''
+    raise NotImplementedError()
+
   def WriteRecommendedPolicy(self, policy):
     '''Appends the template text corresponding to a recommended policy into the
     internal buffer.
 
     Args:
       policy: The recommended policy as it is found in the JSON file.
     '''
     # TODO
     #raise NotImplementedError()
     pass
@@ skipping 89 matching lines @@
     '''
     is_group = policy['type'] == 'group'
     if is_group:
       # Groups are sorted by caption.
       str_key = policy['caption']
     else:
       # Regular policies are sorted by name.
       str_key = policy['name']
     # Groups come before regular policies.
     return (not is_group, str_key)