Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 631223002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/[fetch|fileapi] (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/[fetch|fileapi] This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -137 lines) Patch
M Source/core/fetch/CSSStyleSheetResource.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/fetch/DocumentResource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/fetch/DocumentResourceReference.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/fetch/ImageResource.h View 4 chunks +20 lines, -20 lines 0 comments Download
M Source/core/fetch/ImageResourceClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/fetch/MemoryCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/MockImageResourceClient.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/RawResource.h View 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 2 chunks +22 lines, -22 lines 0 comments Download
M Source/core/fetch/ResourceLoader.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/fetch/ResourceLoaderSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fetch/StyleSheetResourceClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/TextResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/Blob.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/Blob.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/File.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/fileapi/FileList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 13:43:54 UTC) #2
Mike West
On 2014/10/07 13:43:54, MRV wrote: > PTAL rs lgtm
6 years, 2 months ago (2014-10-07 13:50:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631223002/1
6 years, 2 months ago (2014-10-07 13:53:28 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:49:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183342

Powered by Google App Engine
This is Rietveld 408576698