Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/browser_signin.cc

Issue 6312154: Remove wstring from RVH's run Javascript command.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/browser_browsertest.cc ('K') | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/chromeos/login/account_screen.cc » ('j') | chrome/browser/debugger/devtools_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_signin.cc
===================================================================
--- chrome/browser/browser_signin.cc (revision 73805)
+++ chrome/browser/browser_signin.cc (working copy)
@@ -169,7 +169,8 @@
return;
RenderViewHost* rvh = dom_ui_->tab_contents()->render_view_host();
- rvh->ExecuteJavascriptInWebFrame(L"//iframe[@id='login']", L"hideBlurb();");
+ rvh->ExecuteJavascriptInWebFrame(ASCIIToUTF16("//iframe[@id='login']"),
+ ASCIIToUTF16("hideBlurb();"));
DictionaryValue json_args;
std::string json;
@@ -188,7 +189,8 @@
base::JSONWriter::Write(&json_args, false, &json);
javascript += L"showGaiaLogin(" + UTF8ToWide(json) + L");";
- rvh->ExecuteJavascriptInWebFrame(L"//iframe[@id='login']", javascript);
+ rvh->ExecuteJavascriptInWebFrame(ASCIIToUTF16("//iframe[@id='login']"),
+ WideToUTF16Hack(javascript));
}
void BrowserSigninHtml::HandleSubmitAuth(const ListValue* args) {
« chrome/browser/browser_browsertest.cc ('K') | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/chromeos/login/account_screen.cc » ('j') | chrome/browser/debugger/devtools_window.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698