Chromium Code Reviews| Index: chrome/test/pyautolib/pyautolib.cc |
| =================================================================== |
| --- chrome/test/pyautolib/pyautolib.cc (revision 73805) |
| +++ chrome/test/pyautolib/pyautolib.cc (working copy) |
| @@ -241,19 +241,22 @@ |
| return s; |
| } |
| -bool PyUITestBase::AddBookmarkGroup(std::wstring& parent_id, int index, |
| - std::wstring& title) { |
| +bool PyUITestBase::AddBookmarkGroup(const std::wstring& parent_id, int index, |
|
Nirnimesh
2011/02/04 21:59:19
string16 here?
Avi (use Gerrit)
2011/02/04 23:02:11
Done.
|
| + const std::wstring& title) { |
| scoped_refptr<BrowserProxy> browser_proxy = |
| automation()->GetBrowserWindow(0); // Window doesn't matter. |
| EXPECT_TRUE(browser_proxy.get()); |
| if (!browser_proxy.get()) |
| return false; |
| - return browser_proxy->AddBookmarkGroup(StringToId(parent_id), index, title); |
| + return browser_proxy->AddBookmarkGroup(StringToId(parent_id), |
| + index, |
| + WideToUTF16Hack(title)); |
| } |
| -bool PyUITestBase::AddBookmarkURL(std::wstring& parent_id, int index, |
| - std::wstring& title, std::wstring& url) { |
| +bool PyUITestBase::AddBookmarkURL(const std::wstring& parent_id, int index, |
| + const std::wstring& title, |
| + const std::wstring& url) { |
| scoped_refptr<BrowserProxy> browser_proxy = |
| automation()->GetBrowserWindow(0); // Window doesn't matter. |
| EXPECT_TRUE(browser_proxy.get()); |
| @@ -261,7 +264,8 @@ |
| return false; |
| return browser_proxy->AddBookmarkURL(StringToId(parent_id), |
| - index, title, |
| + index, |
| + WideToUTF16Hack(title), |
| GURL(WideToUTF8(url))); |
| } |
| @@ -285,7 +289,8 @@ |
| if (!browser_proxy.get()) |
| return false; |
| - return browser_proxy->SetBookmarkTitle(StringToId(id), title); |
| + return browser_proxy->SetBookmarkTitle(StringToId(id), |
| + WideToUTF16Hack(title)); |
| } |
| bool PyUITestBase::SetBookmarkURL(std::wstring& id, std::wstring& url) { |
| @@ -331,18 +336,19 @@ |
| scoped_refptr<BrowserProxy> browser_proxy = |
| automation()->GetBrowserWindow(window_index); |
| EXPECT_TRUE(browser_proxy.get()); |
| - std::wstring response; |
| if (!browser_proxy.get()) |
| - return response; |
| + return std::wstring(); |
| scoped_refptr<TabProxy> tab_proxy = |
| browser_proxy->GetTab(tab_index); |
| EXPECT_TRUE(tab_proxy.get()); |
| if (!tab_proxy.get()) |
| - return response; |
| + return std::wstring(); |
| - EXPECT_TRUE(tab_proxy->ExecuteAndExtractString(frame_xpath, script, |
| + string16 response; |
| + EXPECT_TRUE(tab_proxy->ExecuteAndExtractString(WideToUTF16Hack(frame_xpath), |
| + WideToUTF16Hack(script), |
| &response)); |
| - return response; |
| + return UTF16ToWideHack(response); |
| } |
| std::wstring PyUITestBase::GetDOMValue(const std::wstring& expr, |