Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: src/store-buffer-inl.h

Issue 6312147: Fix some correctness issues with the store buffer shown up by... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/store-buffer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/store-buffer-inl.h
===================================================================
--- src/store-buffer-inl.h (revision 6616)
+++ src/store-buffer-inl.h (working copy)
@@ -52,6 +52,22 @@
}
+void StoreBuffer::set_store_buffer_mode(StoreBuffer::StoreBufferMode mode) {
+ if (FLAG_trace_gc) {
+ if (mode != store_buffer_mode_) {
+ if (mode == kStoreBufferDisabled) {
+ PrintF("Store buffer overflowed.\n");
+ } else if (mode == kStoreBufferBeingRebuilt) {
+ PrintF("Store buffer being rebuilt.\n");
+ } else if (mode == kStoreBufferFunctional) {
+ PrintF("Store buffer reenabled.\n");
+ }
+ }
+ }
+ store_buffer_mode_ = mode;
+}
+
+
void StoreBuffer::EnterDirectlyIntoStoreBuffer(Address addr) {
if (store_buffer_rebuilding_enabled_) {
Address* top = old_top_;
@@ -59,9 +75,10 @@
old_top_ = top;
if (top >= old_limit_) {
Counters::store_buffer_overflows.Increment();
- store_buffer_mode_ = kStoreBufferDisabled;
+ set_store_buffer_mode(kStoreBufferDisabled);
old_top_ = old_start_;
}
+ old_buffer_is_sorted_ = false;
}
}
« no previous file with comments | « src/store-buffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698