Issue 6312048: Redo normal expressions in dialog updater to be thread-safe

Issue 6312048: Redo normal expressions in dialog updater to be thread-safe (Closed)

Created:
9 years, 10 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
apavlov

CC:
chromedevtools-dev_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

Description

Redo normal expressions in dialog updater to be thread-safe Committed: http://code.google.com/p/chromedevtools/source/detail?r=483

Patch Set 3 : follow codereview #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+342 lines, -121 lines)			Patch
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/DialogUtils.java	View	1	8 chunks	+271 lines, -60 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/WizardUtils.java	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java	View	1 2	9 chunks	+68 lines, -58 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apavlov

LGTM with comments http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java File plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java (right): http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java#newcode146 plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java:146: public ValueSource<? extends Optional<? extends FinisherDelegate>> ...

9 years, 10 months ago (2011-02-01 18:05:37 UTC) #2

Peter Rybin

9 years, 10 months ago (2011-02-01 19:28:04 UTC) #3

I'm terribly sorry for format flaws -- I totally overlooked them :(

http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.u...
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java
(right):

http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.u...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java:146:
public ValueSource<? extends Optional<? extends FinisherDelegate>>
getWizardFinisherDelegateSource() {
On 2011/02/01 18:05:37, apavlov wrote:
> line too long

Done.

http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.u...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java:244:
//    final ValueProcessor<Optional<LiveEditDiffViewer.Input>> previewValue =
On 2011/02/01 18:05:37, apavlov wrote:
> can we refrain from committing commented code?

Done.

http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.u...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java:275:
public Optional<? extends LiveEditDiffViewer.Input> calculate(ChangeDescription
previewRawResultParam) {
On 2011/02/01 18:05:37, apavlov wrote:
> line too long

Done.

http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.u...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java:295:
public ValueSource<Optional<UpdatableScript.ChangeDescription>>
previewRawResultValueSource() {
On 2011/02/01 18:05:37, apavlov wrote:
> line too long

Done.

http://codereview.chromium.org/6312048/diff/2001/plugins/org.chromium.debug.u...
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java:387:
public ValueSource<? extends Optional<? extends List<ScriptTargetMapping>>>
getSelectVmSource() {
On 2011/02/01 18:05:37, apavlov wrote:
> line too long

Done.

Expand Messages | Collapse Messages