Fix bug: AppShell: CHECK failure in PeerConnection init.

content/shell/browser/shell_browser_context.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_SHELL_BROWSER_SHELL_BROWSER_CONTEXT_H_
 #define CONTENT_SHELL_BROWSER_SHELL_BROWSER_CONTEXT_H_
 
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
@@ skipping 16 matching lines @@
 class ShellBrowserContext : public BrowserContext {
  public:
   ShellBrowserContext(bool off_the_record, net::NetLog* net_log);
   virtual ~ShellBrowserContext();
 
   void set_guest_manager_for_testing(
       BrowserPluginGuestManager* guest_manager) {
     guest_manager_ = guest_manager;
   }
 
+  void set_url_request_context_getter(ShellURLRequestContextGetter* getter);

[James Cook, 2014/10/07 16:24:54]

I would make these methods protected to help emphasize that only subclasses
should call them.

Also, since they are not inlined:
SetURLRequestContextGetter();
GetURLRequestContextGetter();

And the first one in particular needs a comment about why it exists.

[Xi Han, 2014/10/07 19:29:53]

Good idea. Make these methods protected, but leave them as inline functions
here. Update the set_url_request_context_getter and make it just work as a
setter.


On 2014/10/07 16:24:54, James Cook wrote:

+  ShellURLRequestContextGetter* get_url_request_context_getter();
+
   // BrowserContext implementation.
   virtual base::FilePath GetPath() const override;
   virtual bool IsOffTheRecord() const override;
   virtual DownloadManagerDelegate* GetDownloadManagerDelegate() override;
   virtual net::URLRequestContextGetter* GetRequestContext() override;
   virtual net::URLRequestContextGetter* GetRequestContextForRenderProcess(
       int renderer_child_id) override;
   virtual net::URLRequestContextGetter* GetMediaRequestContext() override;
   virtual net::URLRequestContextGetter* GetMediaRequestContextForRenderProcess(
       int renderer_child_id) override;
@@ skipping 31 matching lines @@
   scoped_ptr<ShellResourceContext> resource_context_;
   scoped_ptr<ShellDownloadManagerDelegate> download_manager_delegate_;
   scoped_refptr<ShellURLRequestContextGetter> url_request_getter_;
 
   DISALLOW_COPY_AND_ASSIGN(ShellBrowserContext);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_SHELL_BROWSER_SHELL_BROWSER_CONTEXT_H_