Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 631183002: Fixing mapping conflicts for required html attribute and aria-required (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebasing Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXNodeObject.cpp
diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp
index 09883e6104ac1c15b031829f0539f4cc86626894..6b9bf8b09f5030ffa6a3f2ed4c3f37b3541cedfc 100644
--- a/Source/modules/accessibility/AXNodeObject.cpp
+++ b/Source/modules/accessibility/AXNodeObject.cpp
@@ -799,13 +799,13 @@ bool AXNodeObject::isReadOnly() const
bool AXNodeObject::isRequired() const
{
- if (equalIgnoringCase(getAttribute(aria_requiredAttr), "true"))
- return true;
-
Node* n = this->node();
if (n && (n->isElementNode() && toElement(n)->isFormControlElement()))
return toHTMLFormControlElement(n)->isRequired();
+ if (equalIgnoringCase(getAttribute(aria_requiredAttr), "true"))
+ return true;
+
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698