A quick fix for Issue 9762 and 9763....

chrome/browser/renderer_host/render_widget_host_view_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/render_widget_host_view_win.h"
 
 #include "base/command_line.h"
 #include "base/gfx/gdi_util.h"
 #include "base/gfx/rect.h"
 #include "base/histogram.h"
@@ skipping 47 matching lines @@
   if (::IsWindowVisible(window)) {
     const HWND owner = ::GetWindow(window, GW_OWNER);
     if (toplevel_hwnd == owner) {
       ::PostMessage(window, WM_CANCELMODE, 0, 0);
     }
   }
 
   return TRUE;
 }
 
+// Returns the text direction according to the keyboard status.
+// This function retrieves the status of all keys and returns the following
+// values:
+// * WEB_TEXT_DIRECTION_RTL
+//   If only a control key and a right-shift key are down.
+// * WEB_TEXT_DIRECTION_LTR
+//   If only a control key and a left-shift key are down.
+static bool GetNewTextDirection(WebTextDirection* direction) {
+  uint8_t keystate[256];
+  if (!GetKeyboardState(&keystate[0]))
+    return false;
+
+  // To check if a user is pressing only a control key and a right-shift key
+  // (or a left-shift key), we use the steps below:
+  // 1. Check if a user is pressing a control key and a right-shift key (or
+  //    a left-shift key).
+  // 2. If the condition 1 is true, we should check if there are any other
+  //    keys pressed at the same time.
+  //    To ignore the keys checked in 1, we set their status to 0 before
+  //    checking the key status.
+  const int kKeyDownMask = 0x80;
+  if ((keystate[VK_CONTROL] & kKeyDownMask) == 0)
+    return false;
+
+  if (keystate[VK_RSHIFT] & kKeyDownMask) {
+    keystate[VK_RSHIFT] = 0;
+    *direction = WEB_TEXT_DIRECTION_RTL;
+  } else if (keystate[VK_LSHIFT] & kKeyDownMask) {
+    keystate[VK_LSHIFT] = 0;
+    *direction = WEB_TEXT_DIRECTION_LTR;
+  } else {
+    return false;
+  }
+
+  // Scan the key status to find pressed keys. We should adandon changing the
+  // text direction when there are other pressed keys.
+  // This code is executed only when a user is pressing a control key and a
+  // right-shift key (or a left-shift key), i.e. we should ignore the status of
+  // the keys: VK_SHIFT, VK_CONTROL, VK_RCONTROL, and VK_LCONTROL.
+  // So, we reset their status to 0 and ignore them.
+  keystate[VK_SHIFT] = 0;
+  keystate[VK_CONTROL] = 0;
+  keystate[VK_RCONTROL] = 0;
+  keystate[VK_LCONTROL] = 0;
+  for (int i = 0; i <= VK_PACKET; ++i) {
+    if (keystate[i] & kKeyDownMask)
+      return false;
+  }
+  return true;
+}
+
 }  // namespace
 
 // RenderWidgetHostView --------------------------------------------------------
 
 // static
 RenderWidgetHostView* RenderWidgetHostView::CreateViewForWidget(
     RenderWidgetHost* widget) {
   return new RenderWidgetHostViewWin(widget);
 }
 
@@ skipping 763 matching lines @@
   if (close_on_deactivate_ &&
       (((message == WM_KEYDOWN || message == WM_KEYUP) && (wparam == VK_TAB)) ||
         (message == WM_CHAR && wparam == L'\t'))) {
     DCHECK(parent_hwnd_);
     // First close the pop-up.
     SendMessage(WM_CANCELMODE);
     // Then move the focus by forwarding the tab key to the parent.
     return ::SendMessage(parent_hwnd_, message, wparam, lparam);
   }
 
-  if (wparam == VK_SHIFT || wparam == VK_CONTROL) {
-    // Bug 1845: we need to update the text direction when a user releases
-    // either a right-shift key or a right-control key after pressing both of
-    // them. So, we just update the text direction while a user is pressing the
-    // keys, and we notify the text direction when a user releases either of
-    // them.
-    if (message == WM_KEYDOWN) {
-      const int kKeyDownMask = 0x8000;
-      if ((GetKeyState(VK_RSHIFT) & kKeyDownMask) &&
-          (GetKeyState(VK_RCONTROL) & kKeyDownMask)) {
-        render_widget_host_->UpdateTextDirection(WEB_TEXT_DIRECTION_RTL);
-      } else if ((GetKeyState(VK_LSHIFT) & kKeyDownMask) &&
-                 (GetKeyState(VK_LCONTROL) & kKeyDownMask)) {
-        render_widget_host_->UpdateTextDirection(WEB_TEXT_DIRECTION_LTR);
-      }
-    } else if (message == WM_KEYUP) {
-      render_widget_host_->NotifyTextDirection();
+  // Bug 1845: we need to update the text direction when a user releases
+  // either a right-shift key or a right-control key after pressing both of
+  // them. So, we just update the text direction while a user is pressing the
+  // keys, and we notify the text direction when a user releases either of them.
+  if (message == WM_KEYDOWN) {
+    if (wparam == VK_SHIFT) {
+      WebTextDirection direction;
+      if (GetNewTextDirection(&direction))
+        render_widget_host_->UpdateTextDirection(direction);
+    } else if (wparam != VK_CONTROL) {
+      // A user pressed a key except shift and control keys.
+      // When a user presses a key while he/she holds control and shift keys,
+      // we adandon sending an IPC message in a succeeding NotifyTextDirection()
+      // call. To adandon it, this call set a flag that prevents sending an IPC
+      // message in NotifyTextDirection() only if we are going to send it.
+      // So, it is harmless to call this function if we aren't going to send it.
+      render_widget_host_->CancelUpdateTextDirection();
     }
+  } else if (message == WM_KEYUP &&
+             (wparam == VK_SHIFT || wparam == VK_CONTROL)) {
+    // We send an IPC message only if we need to update the text direction.
+    render_widget_host_->NotifyTextDirection();
   }
 
   render_widget_host_->ForwardKeyboardEvent(
       NativeWebKeyboardEvent(m_hWnd, message, wparam, lparam));
   return 0;
 }
 
 LRESULT RenderWidgetHostViewWin::OnWheelEvent(UINT message, WPARAM wparam,
                                               LPARAM lparam, BOOL& handled) {
   // Workaround for Thinkpad mousewheel driver. We get mouse wheel/scroll
@@ skipping 211 matching lines @@
     // WM_LBUTTONDOWN.
     SetFocus();
   }
 }
 
 void RenderWidgetHostViewWin::ShutdownHost() {
   shutdown_factory_.RevokeAll();
   render_widget_host_->Shutdown();
   // Do not touch any members at this point, |this| has been deleted.
 }