Mac - show user manager before opening browser.

chrome/browser/profiles/profile_window.cc

Index: chrome/browser/profiles/profile_window.cc
diff --git a/chrome/browser/profiles/profile_window.cc b/chrome/browser/profiles/profile_window.cc
index 93524af7637413dec75f2a1973150844ddd1a9de..382aeec5beef506cd68320f199e7866f4eb65b14 100644
--- a/chrome/browser/profiles/profile_window.cc
+++ b/chrome/browser/profiles/profile_window.cc
@@ -155,7 +155,8 @@ void OnUserManagerGuestProfileCreated(
 
   if (tutorial_mode == profiles::USER_MANAGER_TUTORIAL_OVERVIEW) {
     page += profiles::kUserManagerDisplayTutorial;
-  } else if (!profile_path_to_focus.empty()) {
+  } else if (!profile_path_to_focus.empty() &&
+             profile_path_to_focus != ProfileManager::GetGuestProfilePath()) {

[noms (inactive), 2014/10/07 21:25:48]

Not sure why this would happen. Up until now, |profile_path_to_focus| was always
the path of a legit, non guest Profile...

[Mike Lerman, 2014/10/08 15:41:37]

It was! Until someone (rhymes with poms) changed code (especially on Mac, CL
585653002) to make the Guest Profile the Last Active Profile, which the
app_controller_mac passes the last active's path as the path for the User
Manager.

As per discussion offline, removing this call but adding a DCHECK in
UserManager*::Show().

     const ProfileInfoCache& cache =
         g_browser_process->profile_manager()->GetProfileInfoCache();
     size_t index = cache.GetIndexOfProfileWithPath(profile_path_to_focus);
@@ -169,6 +170,9 @@ void OnUserManagerGuestProfileCreated(
   } else if (profile_open_action ==
              profiles::USER_MANAGER_SELECT_PROFILE_ABOUT_CHROME) {
     page += profiles::kUserManagerSelectProfileAboutChrome;
+  } else if (profile_open_action ==
+             profiles::USER_MANAGER_SELECT_PROFILE_CHROME_SETTINGS) {
+    page += profiles::kUserManagerSelectProfileChromeSettings;
   }
   callback.Run(guest_profile, page);
 }
@@ -190,6 +194,7 @@ namespace profiles {
 const char kUserManagerDisplayTutorial[] = "#tutorial";
 const char kUserManagerSelectProfileTaskManager[] = "#task-manager";
 const char kUserManagerSelectProfileAboutChrome[] = "#about-chrome";
+const char kUserManagerSelectProfileChromeSettings[] = "#chrome-settings";
 
 void FindOrCreateNewWindowForProfile(
     Profile* profile,