Mac - show user manager before opening browser.

chrome/browser/app_controller_mac_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 #import <Foundation/Foundation.h>
 #import <Foundation/NSAppleEventDescriptor.h>
 #import <objc/message.h>
 #import <objc/runtime.h>
@@ skipping 260 matching lines @@
   BOOL result = [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:NO];
   EXPECT_FALSE(result);
 
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(1u, active_browser_list_->size());
   EXPECT_TRUE(UserManager::IsShowing());
   UserManager::Hide();
 }
 
+

[noms (inactive), 2014/10/30 17:45:11]

nit: is there an extra \n here?

[Mike Lerman, 2014/10/30 18:06:01]

Done.

+IN_PROC_BROWSER_TEST_F(AppControllerNewProfileManagementBrowserTest,
+                       AboutChromeForcesUserManager) {
+  base::scoped_nsobject<AppController> ac([[AppController alloc] init]);
+
+  // Create the guest profile, and set it as the last used profile so the
+  // app controller can use it on init.
+  CreateAndWaitForGuestProfile();
+  PrefService* local_state = g_browser_process->local_state();
+  local_state->SetString(prefs::kProfileLastUsed, chrome::kGuestProfileDir);
+
+  // Prohibiting guest mode forces the user manager flow for About Chrome.
+  local_state->SetBoolean(prefs::kBrowserGuestModeEnabled, false);
+
+  Profile* guest_profile = [ac lastProfile];
+  EXPECT_EQ(ProfileManager::GetGuestProfilePath(), guest_profile->GetPath());
+  EXPECT_TRUE(guest_profile->IsGuestSession());
+
+  // Tell the browser to open About Chrome

[noms (inactive), 2014/10/30 17:45:11]

nit: comment should end in a .

[Mike Lerman, 2014/10/30 18:06:01]

Done.

+  EXPECT_EQ(1u, active_browser_list_->size());
+  [ac orderFrontStandardAboutPanel:NSApp];
+
+  base::RunLoop().RunUntilIdle();
+
+  // No new browser is opened; the User Manager opens instead.
+  EXPECT_EQ(1u, active_browser_list_->size());
+  EXPECT_TRUE(UserManager::IsShowing());

[noms (inactive), 2014/10/30 17:45:11]

I think you have to explicitly call UserManager::Hide(); like in the other
tests, or else the test won't die (because the UserManager messes with the
application lifecycle)

[Mike Lerman, 2014/10/30 18:06:01]

Done.

+}
+
 class AppControllerOpenShortcutBrowserTest : public InProcessBrowserTest {
  protected:
   AppControllerOpenShortcutBrowserTest() {
   }
 
   void SetUpInProcessBrowserTestFixture() override {
     // In order to mimic opening shortcut during browser startup, we need to
     // send the event before -applicationDidFinishLaunching is called, but
     // after AppController is loaded.
     //
@@ skipping 32 matching lines @@
 };
 
 IN_PROC_BROWSER_TEST_F(AppControllerOpenShortcutBrowserTest,
                        OpenShortcutOnStartup) {
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   EXPECT_EQ(g_open_shortcut_url,
       browser()->tab_strip_model()->GetActiveWebContents()
           ->GetLastCommittedURL());
 }
 
+

[noms (inactive), 2014/10/30 17:45:11]

nit: i think there's an extra \n?

[Mike Lerman, 2014/10/30 18:06:01]

Done.

 }  // namespace