Mac - show user manager before opening browser.

chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/user_manager_screen_handler.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/value_conversions.h"
@@ skipping 14 matching lines @@
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/user_manager.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "google_apis/gaia/gaia_auth_fetcher.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/webui/web_ui_util.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
@@ skipping 665 matching lines @@
                 IDS_LOGIN_ERROR_AUTHENTICATING)),
         base::StringValue(""),
         base::FundamentalValue(0));
   }
 }
 
 void UserManagerScreenHandler::OnBrowserWindowReady(Browser* browser) {
   DCHECK(browser);
   DCHECK(browser->window());
   if (url_hash_ == profiles::kUserManagerSelectProfileTaskManager) {
-     base::MessageLoop::current()->PostTask(
-         FROM_HERE, base::Bind(&chrome::ShowTaskManager, browser));
+    content::RecordAction(base::UserMetricsAction("TaskManager"));

[Mark Mentovai, 2014/10/07 20:22:57]

Seems weird that some things have their UMA actions recorded from this file.
Shouldn’t this happen in a more centralized location, like in ShowTaskManager?

[Mike Lerman, 2014/10/08 15:41:37]

This generally happens in the chrome::OpenTaskManager method, which calls
ShowTaskManager. I've changed the call to that method and removed the
RecordAction here.

+    base::MessageLoop::current()->PostTask(
+        FROM_HERE, base::Bind(&chrome::ShowTaskManager, browser));
   } else if (url_hash_ == profiles::kUserManagerSelectProfileAboutChrome) {
-     base::MessageLoop::current()->PostTask(
-         FROM_HERE, base::Bind(&chrome::ShowAboutChrome, browser));
+    base::MessageLoop::current()->PostTask(
+        FROM_HERE, base::Bind(&chrome::ShowAboutChrome, browser));
+  } else if (url_hash_ == profiles::kUserManagerSelectProfileChromeSettings) {
+    base::MessageLoop::current()->PostTask(
+        FROM_HERE, base::Bind(&chrome::ShowSettings, browser));
   }
 
   // This call is last as it deletes this object.
   UserManager::Hide();
 }
 
 void UserManagerScreenHandler::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
@@ skipping 19 matching lines @@
     Profile* profile, Profile::CreateStatus profile_create_status) {
   Browser* browser = chrome::FindAnyBrowser(profile, false, desktop_type_);
   if (browser && browser->window()) {
     OnBrowserWindowReady(browser);
   } else {
     registrar_.Add(this,
                    chrome::NOTIFICATION_BROWSER_WINDOW_READY,
                    content::NotificationService::AllSources());
   }
 }