Mac - show user manager before opening browser.

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 187 matching lines @@
   if (!switches::IsNewProfileManagement())
     return false;
   ProfileInfoCache& cache =
       g_browser_process->profile_manager()->GetProfileInfoCache();
   size_t profile_index = cache.GetIndexOfProfileWithPath(profile->GetPath());
   if (profile_index == std::string::npos)
     return false;
   return cache.ProfileIsSigninRequiredAtIndex(profile_index);
 }
 
+bool IsGuestModeEnabled() {
+  const PrefService* prefs = g_browser_process->local_state();
+  return prefs->GetBoolean(prefs::kBrowserGuestModeEnabled);
+}
+
 }  // anonymous namespace
 
 @interface AppController (Private)
 - (void)initMenuState;
 - (void)initProfileMenu;
 - (void)updateConfirmToQuitPrefMenuItem:(NSMenuItem*)item;
 - (void)updateDisplayMessageCenterPrefMenuItem:(NSMenuItem*)item;
 - (void)registerServicesMenuTypesTo:(NSApplication*)app;
 - (void)openUrls:(const std::vector<GURL>&)urls;
 - (void)getUrl:(NSAppleEventDescriptor*)event
@@ skipping 876 matching lines @@
       else
         chrome::OpenHelpWindow(lastProfile, chrome::HELP_SOURCE_MENU);
       break;
     case IDC_SHOW_SYNC_SETUP:
       if (Browser* browser = ActivateBrowser(lastProfile)) {
         chrome::ShowBrowserSignin(browser, signin::SOURCE_MENU);
       } else {
         chrome::OpenSyncSetupWindow(lastProfile, signin::SOURCE_MENU);
       }
       break;
     case IDC_TASK_MANAGER:

[Mark Mentovai, 2014/10/07 20:22:57]

How does the task manager interact with this? It’s native, not web UI.

[Mike Lerman, 2014/10/08 15:41:37]

Web UI can be launched from the "Stats for nerds" link. We decided, for
consistency, to gate the Task Manager the same way we do About Chrome.

[Mark Mentovai, 2014/10/08 16:43:22]

Mike Lerman wrote:
As opposed to just redirecting the “stats for nerds” click to the profile
chooser? I dunno about that.

[Mike Lerman, 2014/10/08 20:23:41]

Ok. I can do this for Mac implementation (Windows has different dependencies
around a Browser being around to open the Task Manager). Done.

-      content::RecordAction(UserMetricsAction("TaskManager"));
-      TaskManagerMac::Show();
+      if ([self safeLastProfileForNewWindows]->IsGuestSession() &&
+          !IsGuestModeEnabled()) {
+        UserManager::Show(lastProfile->GetPath(),
+                          profiles::USER_MANAGER_NO_TUTORIAL,
+                          profiles::USER_MANAGER_SELECT_PROFILE_TASK_MANAGER);
+      } else {
+        content::RecordAction(UserMetricsAction("TaskManager"));
+        TaskManagerMac::Show();
+      }
       break;
     case IDC_OPTIONS:
       [self showPreferences:sender];
       break;
   }
 }
 
 // Run a (background) application in a new tab.
 - (void)executeApplication:(id)sender {
   NSInteger tag = [sender tag];
@@ skipping 258 matching lines @@
 }
 
 // Show the preferences window, or bring it to the front if it's already
 // visible.
 - (IBAction)showPreferences:(id)sender {
   if (Browser* browser = ActivateBrowser([self lastProfile])) {
     // Show options tab in the active browser window.
     chrome::ShowSettings(browser);
   } else {
     // No browser window, so create one for the options tab.
-    chrome::OpenOptionsWindow([self safeLastProfileForNewWindows]);
+    Profile* lastProfile = [self safeLastProfileForNewWindows];
+    if (lastProfile->IsGuestSession() && !IsGuestModeEnabled()) {
+      UserManager::Show(lastProfile->GetPath(),
+                        profiles::USER_MANAGER_NO_TUTORIAL,
+                        profiles::USER_MANAGER_SELECT_PROFILE_CHROME_SETTINGS);
+    } else {
+      chrome::OpenOptionsWindow([self safeLastProfileForNewWindows]);
+    }
   }
 }
 
 - (IBAction)orderFrontStandardAboutPanel:(id)sender {
   if (Browser* browser = ActivateBrowser([self lastProfile])) {
     chrome::ShowAboutChrome(browser);
   } else {
     // No browser window, so create one for the about tab.
-    chrome::OpenAboutWindow([self safeLastProfileForNewWindows]);
+    Profile* lastProfile = [self safeLastProfileForNewWindows];
+    if (lastProfile->IsGuestSession() && !IsGuestModeEnabled()) {

[Mark Mentovai, 2014/10/07 20:22:57]

This is getting kind of repetitive. Maybe it could be refactored so that you
could have

// Returns true if it’s safe to open a new browser. Otherwise, shows the user
picker and returns false.
bool CanOpenNewBrowser();

- orderFrontStandardAboutPanel:(id)sender {
  if (ActivateBrowser(…)) {
    chrome::ShowAboutChrome(…);
  } else if (CanOpenNewBrowser()) {
    chrome::OpenAboutWindow(…);
  }
}

[Mike Lerman, 2014/10/08 15:41:37]

Done - refactored.

+      UserManager::Show(lastProfile->GetPath(),
+                        profiles::USER_MANAGER_NO_TUTORIAL,
+                        profiles::USER_MANAGER_SELECT_PROFILE_ABOUT_CHROME);
+    } else {
+      chrome::OpenAboutWindow([self safeLastProfileForNewWindows]);
+    }
   }
 }
 
 - (IBAction)toggleConfirmToQuit:(id)sender {
   PrefService* prefService = g_browser_process->local_state();
   bool enabled = prefService->GetBoolean(prefs::kConfirmToQuitEnabled);
   prefService->SetBoolean(prefs::kConfirmToQuitEnabled, !enabled);
 }
 
 - (IBAction)toggleDisplayMessageCenter:(id)sender {
@@ skipping 175 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac